FIX: createPermission, updatePermission, and deletePermission logics

This commit is contained in:
MohammadHMazarei
2024-12-24 21:19:20 +03:30
parent e02b567c16
commit 3fef3759dd
+9 -8
View File
@@ -5,11 +5,8 @@ module.exports.getAllPermissions = async () => {
return Permission.find({}) return Permission.find({})
} }
module.exports.createPermission = async (englishName, persianName) => { module.exports.createPermission = async (data) => {
return await Permission.create({ return await Permission.create(data)
englishName,
persianName,
})
} }
module.exports.getPermission = async (permissionId) => { module.exports.getPermission = async (permissionId) => {
@@ -22,8 +19,8 @@ module.exports.getPermission = async (permissionId) => {
return permission return permission
} }
module.exports.updatePermission = async (data) => { module.exports.updatePermission = async (permissionId, data) => {
const permission = await Permission.findOneAndUpdate(data) const permission = await Permission.findOneAndUpdate({ _id: permissionId }, data, { new: true })
if (!permission) { if (!permission) {
throw AppError('NoPermissionFound', 404, {}) throw AppError('NoPermissionFound', 404, {})
@@ -33,7 +30,11 @@ module.exports.updatePermission = async (data) => {
} }
module.exports.deletePermission = async (permissionId) => { module.exports.deletePermission = async (permissionId) => {
await Permission.findOneAndDelete({ _id: permissionId }) const permission = await Permission.findOneAndDelete({ _id: permissionId })
if (!permission) {
throw AppError('NoPermissionFound', 404, {})
}
return null return null
} }