From 3fef3759dda1cfd63d2178964a6223ac648da51b Mon Sep 17 00:00:00 2001
From: MohammadHMazarei <mazareimohammadhosein@gmail.com>
Date: Tue, 24 Dec 2024 21:19:20 +0330
Subject: [PATCH] FIX: createPermission, updatePermission, and deletePermission
 logics

---
 components/permission/permissionService.js | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/components/permission/permissionService.js b/components/permission/permissionService.js
index c928d90..69a71ad 100644
--- a/components/permission/permissionService.js
+++ b/components/permission/permissionService.js
@@ -5,11 +5,8 @@ module.exports.getAllPermissions = async () => {
     return Permission.find({})
 }
 
-module.exports.createPermission = async (englishName, persianName) => {
-    return await Permission.create({
-        englishName,
-        persianName,
-    })
+module.exports.createPermission = async (data) => {
+    return await Permission.create(data)
 }
 
 module.exports.getPermission = async (permissionId) => {
@@ -22,8 +19,8 @@ module.exports.getPermission = async (permissionId) => {
     return permission
 }
 
-module.exports.updatePermission = async (data) => {
-    const permission = await Permission.findOneAndUpdate(data)
+module.exports.updatePermission = async (permissionId, data) => {
+    const permission = await Permission.findOneAndUpdate({ _id: permissionId }, data, { new: true })
 
     if (!permission) {
         throw AppError('NoPermissionFound', 404, {})
@@ -33,7 +30,11 @@ module.exports.updatePermission = async (data) => {
 }
 
 module.exports.deletePermission = async (permissionId) => {
-    await Permission.findOneAndDelete({ _id: permissionId })
+    const permission = await Permission.findOneAndDelete({ _id: permissionId })
+
+    if (!permission) {
+        throw AppError('NoPermissionFound', 404, {})
+    }
 
     return null
 }