diff --git a/components/permission/permissionService.js b/components/permission/permissionService.js index c928d90..69a71ad 100644 --- a/components/permission/permissionService.js +++ b/components/permission/permissionService.js @@ -5,11 +5,8 @@ module.exports.getAllPermissions = async () => { return Permission.find({}) } -module.exports.createPermission = async (englishName, persianName) => { - return await Permission.create({ - englishName, - persianName, - }) +module.exports.createPermission = async (data) => { + return await Permission.create(data) } module.exports.getPermission = async (permissionId) => { @@ -22,8 +19,8 @@ module.exports.getPermission = async (permissionId) => { return permission } -module.exports.updatePermission = async (data) => { - const permission = await Permission.findOneAndUpdate(data) +module.exports.updatePermission = async (permissionId, data) => { + const permission = await Permission.findOneAndUpdate({ _id: permissionId }, data, { new: true }) if (!permission) { throw AppError('NoPermissionFound', 404, {}) @@ -33,7 +30,11 @@ module.exports.updatePermission = async (data) => { } module.exports.deletePermission = async (permissionId) => { - await Permission.findOneAndDelete({ _id: permissionId }) + const permission = await Permission.findOneAndDelete({ _id: permissionId }) + + if (!permission) { + throw AppError('NoPermissionFound', 404, {}) + } return null }